On Fri, 2011-07-29 at 16:59 -0400, Justin Piszcz wrote: > On Fri, 29 Jul 2011, Bryan Schumaker wrote: > > > How does this look for printing out more information when a cookie loop is detected? Is there anything else that should be printed out? My patch applies on top of Trond's from yesterday. > > > Hi, > > This fails against 2.6.38: > > patching file fs/nfs/dir.c > Hunk #1 FAILED at 134. > Hunk #2 FAILED at 173. > Hunk #3 FAILED at 323. > Hunk #4 FAILED at 336. > Hunk #5 FAILED at 349. > Hunk #6 succeeded at 320 (offset -48 lines). > Hunk #7 FAILED at 741. > Hunk #8 succeeded at 716 (offset -59 lines). > Hunk #9 succeeded at 749 (offset -59 lines). > Hunk #10 succeeded at 763 (offset -59 lines). > 6 out of 10 hunks FAILED -- saving rejects to file fs/nfs/dir.c.rej > patching file include/linux/nfs_fs.h > Hunk #1 FAILED at 99. > 1 out of 1 hunk FAILED -- saving rejects to file include/linux/nfs_fs.h.rej > atom:/usr/src/linux# > > And the 3.0 kernel is broken for my wireless adapter: > http://www.gossamer-threads.com/lists/linux/kernel/1411576 > > If you can make a combined patch for 2.6.38 I can try it, 2.6.39+ have a > horrible driver (rt2800usb) and 1 person emailed me as well stating the > same thing off-list (they stick with the manufacturer's driver or the *sta > one). I don't understand. The readdir loop detection code was first merged upstream in 2.6.39. 2.6.38 doesn't report any loops... -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
