Re: More TMIO MMC variant. What is a preferred name?

[Wolfram Sang <wsa@xxxxxxxxxxxxx>]

Yamada-san, Ulf,

> How about CONFIG names and functions?
> Prefix CONFIG options with CONFIG_MMC_TMIO ?

To be precise, I'd favour this:

# core
obj-$(CONFIG_MMC_TMIO_CORE)           += tmio_mmc_core.o
# TMIO-builtin MMC
obj-$(CONFIG_MMC_TMIO_ORIGINAL)       += tmio_mmc_original.o
# Reneses
obj-$(CONFIG_MMC_TMIO_SDHI_CORE)      += tmio_mmc_sdhi_core.o
# UniPhier
obj-$(CONFIG_MMC_TMIO_UNIPHIER)       += tmio_mmc_uniphier.o

But I am not sure if renaming CONFIG_MMC_TMIO to
CONFIG_MMC_TMIO_ORIGINAL is a regression risk?

> What should I do for function names?
> Shall I start with tmio_mmc_uniphier_ ?

I'll leave this to you and Ulf. If we e.g. rename "renesas_sdhi_core.c"
to "tmio_mmc_sdhi_core.c", I would still leave the function names as is
(prefixed with 'renesas_sdhi_*'). I wouldn't mind your functions
starting with "uniphier_mmc_" even, but that's just me.

Thanks,

   Wolfram

Attachment: signature.asc
Description: PGP signature