2017-11-28 2:14 GMT+09:00 Wolfram Sang <wsa@xxxxxxxxxxxxx>: > >> > Another try: >> > >> >> # core >> >> obj-$(CONFIG_MMC_TMIO_CORE) += tmio_mmc_core.o >> >> # TMIO-builtin MMC >> >> obj-$(CONFIG_MMC_TMIO) += tmio_mmc_original.o >> >> # Reneses >> >> obj-$(CONFIG_MMC_SDHI) += tmio_mmc_sdhi_core.o >> >> # UniPhier >> >> obj-$(CONFIG_MMC_UNIPHIER) += tmio_mmc_uniphier.o >> > >> > I left the Kconfig symbols for easier updating and concentrated on the >> > filenames for now. >> > >> >> Looks good to me! > > Yamada-san? Basically, looks good to me, although I'd like to know our goal before we agree with it. How about CONFIG names and functions? Prefix CONFIG options with CONFIG_MMC_TMIO ? # core obj-$(CONFIG_MMC_TMIO_CORE) += tmio_mmc_core.o # TMIO-builtin MMC obj-$(CONFIG_MMC_TMIO) += tmio_mmc_original.o # Reneses obj-$(CONFIG_MMC_TMIO_SDHI) += tmio_mmc_sdhi_core.o # UniPhier obj-$(CONFIG_MMC_TMIO_UNIPHIER) += tmio_mmc_uniphier.o Or, like follows? # core obj-$(CONFIG_MMC_TMIO) += tmio_mmc.o # TMIO-builtin MMC obj-$(CONFIG_MMC_TMIO_ORIGINAL) += tmio_mmc_original.o # Reneses obj-$(CONFIG_MMC_TMIO_SDHI) += tmio_mmc_sdhi_core.o # UniPhier obj-$(CONFIG_MMC_TMIO_UNIPHIER) += tmio_mmc_uniphier.o What should I do for function names? Shall I start with tmio_mmc_uniphier_ ? -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
