Hi Ulf, thanks for the feedback! > So what do you think of this?: > > 1) Rename tmio_core.c to tmio.c, and fold in some more information > about the history of the IP in the header of the file. Yeah, "tmio" > may not be the absolutely correct name, but on the other hand it > preserves consistency and I there are no need to rename any functions. > 2) Rename tmio_mmc.h to tmio.h - and move potential tmio_mmc specific > bits to tmio_mmc.c. > 3) Rename renesas_sdhi_core.c to tmio_renesas_sdhi.c. Again, I don't > think we need any functions to be renamed because of this change. > 4) Rename renesas_sdhi.h to tmio_renesas_sdhi.h. I can agree to that. Clarifying 3), I think though, we should have: tmio_sdhi.c and on top of that: tmio_sdhi_internal_dmac.c tmio_sdhi_sys_dmac.c ? > Following the naming strategy from the above, I the new file name for > new tmio variant should be tmio_uniphier.c. Yes. Kind regards, Wolfram
Attachment:
signature.asc
Description: PGP signature