> > > > /* > > * NOTE: > > * Expect the breakpoint instruction to be the smallest size instruction for > > * the architecture. If an arch has variable length instruction and the > > * breakpoint instruction is not of the smallest length instruction > > * supported by that architecture then we need to modify read_opcode / > > * write_opcode accordingly. This would never be a problem for archs that > > * have fixed length instructions. > > */ > > Whoever reads comments anyway? :-) > > > Do we have archs which have a breakpoint instruction which isnt of the > > smallest instruction size for that arch. If we do have can we change the > > write_opcode/read_opcode while we support that architecture? > > Why not put a simple WARN_ON_ONCE() in there that checks the assumption? Okay, will do. -- Thanks and Regards Srikar -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>