On Tue, 2011-06-07 at 18:28 +0530, Srikar Dronamraju wrote: > +/** > + * __replace_page - replace page in vma by new page. > + * based on replace_page in mm/ksm.c > + * > + * @vma: vma that holds the pte pointing to page > + * @page: the cowed page we are replacing by kpage > + * @kpage: the modified page we replace page by > + * > + * Returns 0 on success, -EFAULT on failure. > + */ > +static int __replace_page(struct vm_area_struct *vma, struct page *page, > + struct page *kpage) This is a verbatim copy of mm/ksm.c:replace_page(), I think I can remember why you did this, but the changelog utterly fails to mention why we need a second copy of this logic (or anything much at all). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>