On Thu, 2 Dec 2010, Zheng, Shaohui wrote: > Why should we add so many interfaces for memory hotplug emulation? Because they are functionally different from real memory hotplug and we want to support different configurations such as mapping memory to a different node id or onlining physical nodes that don't exist. They are in debugfs because the emulation, unlike real memory hotplug, is used only for testing and debugging. > If so, we should create both sysfs and debugfs > entries for an online node, we are trying to add redundant code logic. > We do not need sysfs triggers for onlining a node, that already happens automatically if the memory that is being onlined has a hotpluggable node entry in the SRAT that has an offline node id. > We need not make a simple thing such complicated, Simple is beautiful, I'd prefer to rename the mem_hotplug/probe > interface as mem_hotplug/add_memory. > > /sys/kernel/debug/mem_hotplug/add_node (already exists) > /sys/kernel/debug/mem_hotplug/add_memory (rename probe as add_memory) > No, add_memory would then require these bizarre lines that you've been parsing like echo 'physical_addr=0x80000000 node_id=3' > /sys/kernel/debug/mem_hotplug/add_memory which is unnecessary if you introduce my proposal for per-node debugfs directories similar to that under /sys/devices/system/node that is extendable later if we add additional per-node triggers under CONFIG_DEBUG_FS. Adding /sys/kernel/debug/mem_hotplug/node2/add_memory that you write a physical address to is a much more robust, simple, and extendable interface. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>