On Wed, Apr 14, 2010 at 1:13 AM, Mel Gorman <mel@xxxxxxxxx> wrote: > On Wed, Apr 14, 2010 at 12:25:03AM +0900, Minchan Kim wrote: >> alloc_pages_exact_node naming makes some people misleading. >> They considered it following as. >> "This function will allocate pages from node which I wanted >> exactly". >> But it can allocate pages from fallback list if page allocator >> can't find free page from node user wanted. >> >> So let's comment this NOTE. >> > > It's a little tough to read. How about > > /* > * Use this instead of alloc_pages_node when the caller knows > * exactly which node they need (as opposed to passing in -1 > * for current). Fallback to other nodes will still occur > * unless __GFP_THISNODE is specified. > */ It is better than mine. > > That at least will tie in why "exact" is in the name? > >> Actually I wanted to change naming with better. >> ex) alloc_pages_explict_node. > > "Explicit" can also be taken to mean "this and only this node". I agree. I will repost modified comment after Tejun comment [2/6]. Thanks for quick review, Mel. :) -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href