On Wed, Apr 14, 2010 at 01:01:31AM +0900, Minchan Kim wrote: > On Wed, Apr 14, 2010 at 12:52 AM, Mel Gorman <mel@xxxxxxxxx> wrote: > > On Wed, Apr 14, 2010 at 12:25:00AM +0900, Minchan Kim wrote: > >> alloc_slab_page never calls alloc_pages_node with -1. > > > > Are you certain? What about > > > > __kmalloc > > -> slab_alloc (passed -1 as a node from __kmalloc) > > -> __slab_alloc > > -> new_slab > > -> allocate_slab > > -> alloc_slab_page > > > > Sorry for writing confusing changelog. > > I means if node == -1 alloc_slab_page always calls alloc_pages. > So we don't need redundant check. > When the changelog is fixed up, feel free to add; Reviewed-by: Mel Gorman <mel@xxxxxxxxx> -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>