On Wed, Apr 14, 2010 at 12:24:58AM +0900, Minchan Kim wrote: > alloc_pages calls alloc_pages_node with numa_node_id(). > alloc_pages_node can't see nid < 0. > > So we can use alloc_pages_exact_node instead of alloc_pages_node. > It could avoid comparison and branch as 6484eb3e2a81807722 tried. > > Cc: Mel Gorman <mel@xxxxxxxxx> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx> Makes sense. Signed-off-by: Mel Gorman <mel@xxxxxxxxx> > --- > include/linux/gfp.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 4c6d413..b65f003 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -308,7 +308,7 @@ extern struct page *alloc_page_vma(gfp_t gfp_mask, > struct vm_area_struct *vma, unsigned long addr); > #else > #define alloc_pages(gfp_mask, order) \ > - alloc_pages_node(numa_node_id(), gfp_mask, order) > + alloc_pages_exact_node(numa_node_id(), gfp_mask, order) > #define alloc_page_vma(gfp_mask, vma, addr) alloc_pages(gfp_mask, 0) > #endif > #define alloc_page(gfp_mask) alloc_pages(gfp_mask, 0) > -- > 1.7.0.5 > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>