On Mon, Apr 5, 2010 at 9:47 PM, Evgeniy Polyakov <zbr@xxxxxxxxxxx> wrote: > On Mon, Apr 05, 2010 at 09:36:00AM +0900, Minchan Kim (minchan.kim@xxxxxxxxx) wrote: >> > All filesystems already call it through find_or_create_page() or >> > grab_page() invoked via read path. In some cases fs has more than >> > one page grabbed via its internal path where data to be read is >> > already placed, so it may want just to add those pages into mm lru. >> >> I understood why it does need that in pohmelfs. >> AFAIU, other file system using general functions(ex, mpage_readpages or >> read_cache_pages) don't need direct LRU handling since it's hided. >> But pohmelfs doesn't use general functions. >> >> Isn't pagevec_lru_add_file enough like other file system(ex, nfs, cifs)? > > This will force to reinvent add_to_page_cache_lru() by doing private > function which will call add_to_page_cache() and pagevec_lru_add_file(), > which is effectively what is being done for file backed pages in > add_to_page_cache_lru(). > > -- > Evgeniy Polyakov Hmm. I found that. http://www.mail-archive.com/linux-btrfs@xxxxxxxxxxxxxxx/msg04472.html Recently, Nick replaced it with add_to_page_cache_lru in btrfs, too. It means other mm guy already knew that and allowed it. Maybe I seem to get paranoid. Sorry for bothering you, Evgeniy and joern. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href