On Sun, 2010-04-04 at 11:27 -0400, Robert P. J. Day wrote: > perusing the code in mm/filemap.c and i'm curious as to why routines > like, for example, add_to_page_cache_lru() are being exported. is it > really expected that loadable modules might access routines like that > directly? It is added by 18bc0bbd162e3 for pohmelfs and now used by logfs, too. I didn't noticed that at that time. With git log, any mm guys didn't add Signed-off-by or Reviewed-by. I think it's not good for file system or module to use it directly. It would make LRU management harder. Is it really needed? Let's think again. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>