On Mon, Apr 05, 2010 at 01:21:52AM +0900, Minchan Kim (minchan.kim@xxxxxxxxx) wrote: > > > It is added by 18bc0bbd162e3 for pohmelfs and now used by logfs, too. > > > I didn't noticed that at that time. > > > With git log, any mm guys didn't add Signed-off-by or Reviewed-by. > > > > > > I think it's not good for file system or module to use it directly. > > > It would make LRU management harder. > > > > How come? > > What I have a concern is that if file systems or some modules start to > overuse it to manage pages LRU directly, some mistake of them would make > system global LRU stupid and make system wrong. All filesystems already call it through find_or_create_page() or grab_page() invoked via read path. In some cases fs has more than one page grabbed via its internal path where data to be read is already placed, so it may want just to add those pages into mm lru. -- Evgeniy Polyakov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>