Hello Sakari On Wed, Sep 11, 2013 at 12:35 AM, Sakari Ailus <sakari.ailus@xxxxxx> wrote: > Hi Ricardo, > > On Fri, Sep 06, 2013 at 10:30:18AM +0200, Ricardo Ribalda Delgado wrote: >> Any comment on this? Of course the names should be better chosen, this >> is just a declaration of intentions. > > I forgot to ask one question: what's the behaviour of cropping on different > regions? Are the regions located on particular line or what? The purpose of this is to increase the framerate on high speed cameras. Lets say you are controlling the speed on a highway. You have a camera looking at the road. The fps will determine the accuracy of your meassurement. If you could skip the reservation between both lanes you could increase the fps. Also imaging a high speed ballistics camera. You have a reference plate on rows 1-10, and you are studing a sample on rows 400-500. You dont want to read rows 11-399, because you will reduce your framerate Finally If you have an scenario where you want to process a specific part of the image at 1mm per pixel and the rest at 10mm per pixel. > > Contrary to the case with AF rectaangles, I see fewer possibilities for > standardising the behaviour of multiple crop rectanges which decreases the > value of a generic interface: even if the interface is generic but you have > no idea what it'd actually do you wouldn't gain much. > > For this reason it might also make sense to use a private IOCTL (and not a > control) to support the functionality. Or private selections (which we don't > have yet). I like the idea of adding an id field to the selection api, and then a private control with a bitmask selection with selections are active. If we can agree on the value of this we could define a standard control. If not, we leave the door open to the drivers to define their own. Thanks for you feedback! -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html