Re: [PATCH v2] [media] gspca: replaced static allocation by video_device_alloc/video_device_release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 11/19/2011 10:46 PM, Ezequiel wrote:
Pushed video_device initialization into a separate function.
Replace static allocation of struct video_device by
video_device_alloc/video_device_release usage.


NACK again! There is no reason to do this, it just makes
the code more complicated without gaining anything. As already
commented by Antonio Ospite your commit message lacks the why of
this patch / the reason to do such a patch. The diffstat clearly
shows it is adding code not removing / simplifying it and it
so doing so without any good reasons!

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux