Re: [PATCH v2] [media] gspca: replaced static allocation by video_device_alloc/video_device_release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 20, 2011 at 11:03:21AM +0100, Hans de Goede wrote:
> NACK again! There is no reason to do this, it just makes
> the code more complicated without gaining anything. As already
> commented by Antonio Ospite your commit message lacks the why of
> this patch / the reason to do such a patch. The diffstat clearly
> shows it is adding code not removing / simplifying it and it
> so doing so without any good reasons!
> 
Yes, it's true: I omit the the reason in the commit message.
The point of the patch was improving readability of the code.

But it was altogether wrong, as Jean-Francois patiently
explained to me in another thread. 

Thanks to you too for the patience,
Ezequiel.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux