On Sat, 19 Nov 2011 18:46:21 -0300 Ezequiel <elezegarcia@xxxxxxxxx> wrote: > Pushed video_device initialization into a separate function. > Replace static allocation of struct video_device by > video_device_alloc/video_device_release usage. > > Signed-off-by: Ezequiel Garcia <elezegarcia@xxxxxxxxx> > --- Hi Ezequiel, just a general comment on commit messages: when doing some invasive changes it is especially important to explain the WHY next to the WHAT and the high-level HOW. [...] > diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c > index 881e04c..1f27f05 100644 > --- a/drivers/media/video/gspca/gspca.c > +++ b/drivers/media/video/gspca/gspca.c > @@ -1292,10 +1292,12 @@ static int vidioc_enum_frameintervals(struct file *filp, void *priv, > [...] Thanks, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Attachment:
pgpRJr0wRhMJG.pgp
Description: PGP signature
