Hi Jonathan, Thanks for your comment. > Similar to what I said in reply to the bindings patch, I would prefer to > have the VCD code and the ECE code in two separate files, if possible, > to make reuse of the VCD code alone (on WPCM450) easier. This video driver is bassed on V4L2 framework to implement the required interfaces, and the V4L2 application in user-space (e.g., openbmc/obmc-ikvm) will interact with these interfaces to get compressed video data for supporting KVM features. In this architecture, for the case of WPCM450 (though it's in EOL for several years), I'd prefer to try to let ECE be an optional node instead of separating ECE code from this V4L2 video driver. However, this patch series could be the base version and keep reviewing, and afterwards we could make another patch for optional ECE, is it OK for you? Regards, Marvin
