Hello, first of all, thank you for bringing this driver upstream. On Fri, May 13, 2022 at 11:34:50AM +0800, Marvin Lin wrote: > Add driver for Video Capture/Differentiation Engine (VCD) and Encoding > Compression Engine (ECE) present on Nuvoton NPCM SoCs. > > Signed-off-by: Marvin Lin <kflin@xxxxxxxxxxx> > --- > drivers/media/platform/Kconfig | 1 + > drivers/media/platform/Makefile | 1 + > drivers/media/platform/nuvoton/Kconfig | 12 + > drivers/media/platform/nuvoton/Makefile | 2 + > drivers/media/platform/nuvoton/npcm-video.c | 2074 +++++++++++++++++++ Similar to what I said in reply to the bindings patch, I would prefer to have the VCD code and the ECE code in two separate files, if possible, to make reuse of the VCD code alone (on WPCM450) easier. Best regards, Jonathan
Attachment:
signature.asc
Description: PGP signature
