Re: [PATCH 7/7] ARM: dts: at91: sama5d4: add vdec0 component

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/03/2021 at 16:57, Emil Velikov wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On Mon, 8 Mar 2021 at 13:21, Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx> wrote:

Hi Emil,

Greetings Nicolas,

So nice to see this support! Thank you so much for handling that.

Little comments below...


Nitpicking: I would use "microchip,sama5d4-vdec". We tend to use the
microchip name for new DT bidings and compatibility strings.

Should i use Microchip (instead of Atmel) only for the DT bindings or
throughout the series?

Yes, everywhere you can (Kconfig, explanation text, ...). Only keep Atmel/atmel where you cannot do differently or if it would require to modify code or move file just for this purpose.

Regards,
  Nicolas

I'm fine with having a "staging" component. Maybe add the hantro vdec as
a module instead.

Ack, will do for v2.

Thanks
Emil



--
Nicolas Ferre



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux