On Mon, 2021-03-08 at 13:07 +0000, Emil Velikov wrote:
> Hi Ezequiel,
>
> Thanks for the prompt reply
>
> On Sat, 6 Mar 2021 at 11:25, Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> wrote:
> >
> > (adding another Nicolas)
> >
> > Hi Emil,
> >
> > Thanks a lot for the patch.
> >
> > On Fri, 2021-03-05 at 18:39 +0000, Emil Velikov wrote:
> > > From: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
> > >
> > > The SoC features a Hantro G1 compatible video decoder.
> > >
> > > Cc: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx>
> > > Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > > Cc: linux-media@xxxxxxxxxxxxxxx
> > > Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx
> > > Signed-off-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
[..]
> > > +static const struct hantro_fmt sama5d4_vdec_postproc_fmts[] = {
> > > + {
> > > + .fourcc = V4L2_PIX_FMT_YUYV,
> > > + .codec_mode = HANTRO_MODE_NONE,
> > > + },
> > > +};
> > > +
> >
> > I haven't found information on how the series
> > was tested in the cover letter, could you add that to the next
> > iteration?
> >
> > Please test the YUYV post-processed output and MPEG-2 decoding as well.
> >
> Any recommendations for MPEG-2 and post-processing testing? For the
> former I could use gstreamer on Big Buck Bunny or other media, yet not
> sure about the latter.
>
The post-processed YUYV output can be requested like this in
GStreamer:
gst-launch-1.0 -v filesrc location=$something ! parsebin ! decodebin ! video/x-raw,format=YUY2 ! ...
For MPEG-2 testing, I'm afraid there's no GStreamer yet for this,
but Jonas' ffmpeg should work https://github.com/Kwiboo/FFmpeg/commits/v4l2-request-hwaccel-4.3.
Thanks,
Ezequiel
