On Mon 2019-09-02 11:02:11, Laurent Pinchart wrote: > Hi Pavel, > > On Sun, Sep 01, 2019 at 07:24:15PM +0200, Pavel Machek wrote: > > > > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > > > > @@ -89,6 +89,10 @@ Optional properties > > > > but a number of degrees counter clockwise. Typical values are 0 and 180 > > > > (upside down). > > > > > > > > +- location: The camera device mounting position, relative to the device > > > > + usage orientation. Possible values are: > > > > + 0 - Front camera. The image sensor is mounted on the front side of the device. > > > > + 1 - Back camera. The image sensor is mounted on the back side of the device. > > > > > > Would it make sense to make this a little more generic? Such as s/image > > > sensor/ device/, for instance? > > > > > > Is this also relevant for flash or lens devices? > > > > > > Flash (torch) devices could be present, at least principle, without a > > > camera. There once was even such a Nokia phone, 1100 unless I'm mistaken. > > > :-) > > > > Well, I'd call them LEDs, not camera flashes ... if there's no camera. And IIRC > > these devices had LEDs on top of the phone... so neither front nor back side. > > I would go for the name "torch" in that case. It really depends on the > device, but in any case, the torch LEDs would have a location (and we > would possibly need to expand this property to > include the top, bottom, left and right sides). Yes, but please let the torch devices be handled by LED subsystem (/sys/class/leds). media/ subsystem is a bit too big and complex for toggling LEDs on and off... Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
