Hello, as anticipared on #v4l, this is a proposal to add a way for camera devices to report their mounting location to user-space. The information on the camera location is particularly meaningful for mobile devices, and in the process of integrating libcamera with the Android camera stack, we found the need to report this information to applications and there's currently no way to retrieve it from the V4L2 API The idea is to provide a camera class read-only control, named 'Location', that is used to report the camera mounting position, which is retrieved from the firmware interface. Hans mentioned v4l2-properties as a better mechanism to report such static informations, but since they're not here I think a control would do for now... The RFC adds a DT standard property to video-interfaces.txt to express the location in DTS (I actually tested it on ACPI, but..), and then adds a new control in the camera class to expose it. Finally, two example sensor drivers I used for testing have been modified to expose the read-only control. Why an RFC: mostly because of the nature and definition of the property. It's tricky to define the "location" semantic clearly as it really depends on the device the camera it is installed on. To begin with, I only defined FRONT and BACK locations, and documented them the best I could. Also the control itself it's probably more appropriate expressed as an integer menu control. However, given the few supported values, and the fact they are standard, I went for a standard integer control and defined a few macros for the possible values as setting up a menu control requires a bit more effort in drivers which I'm not sure it is worth it. I tried out a few different names for the property as well, such as "orientation", "position", "mounting-position" but none of them really satisfied me, so I picked the most simple one. Feedbacks are welcome here too. Thanks j Jacopo Mondi (5): media: dt-bindings: Document 'location' property media: v4l2-ctrl: Document V4L2_CID_LOCATION media: v4l2-ctrls: Add support for V4L2_CID_LOCATION media: i2c: ov5670: Report the camera location media: i2c: ov13858: Report the camera location .../bindings/media/video-interfaces.txt | 4 ++++ .../media/uapi/v4l/ext-ctrls-camera.rst | 23 +++++++++++++++++++ drivers/media/i2c/ov13858.c | 11 +++++++++ drivers/media/i2c/ov5670.c | 11 +++++++++ drivers/media/v4l2-core/v4l2-ctrls.c | 7 ++++++ include/uapi/linux/v4l2-controls.h | 4 ++++ 6 files changed, 60 insertions(+) -- 2.22.0
