On 07/10/2009 06:16 PM, Devin Heitmueller wrote:
On Fri, Jul 10, 2009 at 8:09 AM, Antti Palosaari<crope@xxxxxx> wrote:
af9013 is correct in my mind. af9013 will return -EINVAL (error invalid
value) in case of first garbage value met (maybe better to switch auto mode
when garbage value meet and print debug log?).
Of course there should be at least debug printing to inform that... but fix
you suggest is better for compatibility. You can do that, it is ok for me.
From a purist standpoint, I agree that the application at fault, and
if it were some no-name application I would just say "fix the broken
application". Except it's not a no-name application - it's mplayer.
Are you familiar with Postel's Law?
No :)
http://en.wikipedia.org/wiki/Postel%27s_Law
Saying "this demod is not going to work properly with all versions of
one of the most popular applications", especially when other demods
handle the condition gracefully, is the sort of thing that causes real
problems for the Linux community.
I'm not the maintainer for this demod, so I'm not the best person to
make such a fix. I spent four hours and debugged the issue as a favor
to Jelle de Jong since he loaned me some hardware a couple of months
ago. I guess I can make the fix, but it's just going to take away
from time better spent on things I am more qualified to work on.
Devin
I will fix that just right now. I think I will change demodulator from
"return error invalid value" to "force detect transmission parameters
automatically" in case of broken parameters given.
thanks,
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
