Em Tue, 30 Jun 2009 11:50:29 -0500 "Karicheri, Muralidharan" <m-karicheri2@xxxxxx> escreveu: > > >> > > >> I had sent a patch to fix the comment formatting. If you wish, you could > >apply it and wait for another that fix the old parameter descriptions. > > > >Fine. It would be better if Hans could add this on his tree, for me to > >import > >it together with the other patches. > > > I have done so. > >> >Hmm... > >> > > >> >+#define CCDC_CID_R_GAIN (V4L2_CID_PRIVATE_BASE + 0) > >> >+#define CCDC_CID_GR_GAIN (V4L2_CID_PRIVATE_BASE + 1) > >> >+#define CCDC_CID_GB_GAIN (V4L2_CID_PRIVATE_BASE + 2) > >> >+#define CCDC_CID_B_GAIN (V4L2_CID_PRIVATE_BASE + 3) > >> > > >> >This is not nice. Such gains are common to other webcam drivers, and > >should > >> >be > >> >part of the common part of V4L2 API. > >> > > >> >In fact, currently, we have it mapped as a general gain as red/blue > >balance. > >> > > >> >+#define CCDC_CID_OFFSET (V4L2_CID_PRIVATE_BASE + 4) > >> > > >> >What does it control? > >> This is to adjust the black level I suppose. But I will re-visit it when > >I do control IOCTL handling as per Hans comment against the patch. > > > >In the specific case of the userspace API changes like the above, I prefer > >to > >have it merged at the original patch > > > So do you expect anything from me on this or will be merged as is? I prefer > the second option and I can send another patch to remove this code. Hmm... the second option is ok, provided that it is at the same pull request of the original patch. I don't want to duplicate controls for existing features. You should note that I'm not asking you to remove that code, but just to use the already existing color balance ioctls, for the existing features, or otherwise to discuss the need of extra controls. The case of image color controlling, we already have several controls: #define V4L2_CID_SATURATION (V4L2_CID_BASE+2) #define V4L2_CID_RED_BALANCE (V4L2_CID_BASE+14) #define V4L2_CID_BLUE_BALANCE (V4L2_CID_BASE+15) #define V4L2_CID_GAMMA (V4L2_CID_BASE+16) #define V4L2_CID_GAIN (V4L2_CID_BASE+19) Also, some got deprecated, since they were just duplicating existing controls, using a different way, as discussed at ML: #define V4L2_CID_BLACK_LEVEL (V4L2_CID_BASE+11) /* Deprecated */ #define V4L2_CID_WHITENESS (V4L2_CID_GAMMA) /* Deprecated */ So, you basically need to rewrite your logic in order to control the device in terms of gain and red/blue balance. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
