>> > >> I had sent a patch to fix the comment formatting. If you wish, you could >apply it and wait for another that fix the old parameter descriptions. > >Fine. It would be better if Hans could add this on his tree, for me to >import >it together with the other patches. > I have done so. >> >Hmm... >> > >> >+#define CCDC_CID_R_GAIN (V4L2_CID_PRIVATE_BASE + 0) >> >+#define CCDC_CID_GR_GAIN (V4L2_CID_PRIVATE_BASE + 1) >> >+#define CCDC_CID_GB_GAIN (V4L2_CID_PRIVATE_BASE + 2) >> >+#define CCDC_CID_B_GAIN (V4L2_CID_PRIVATE_BASE + 3) >> > >> >This is not nice. Such gains are common to other webcam drivers, and >should >> >be >> >part of the common part of V4L2 API. >> > >> >In fact, currently, we have it mapped as a general gain as red/blue >balance. >> > >> >+#define CCDC_CID_OFFSET (V4L2_CID_PRIVATE_BASE + 4) >> > >> >What does it control? >> This is to adjust the black level I suppose. But I will re-visit it when >I do control IOCTL handling as per Hans comment against the patch. > >In the specific case of the userspace API changes like the above, I prefer >to >have it merged at the original patch > So do you expect anything from me on this or will be merged as is? I prefer the second option and I can send another patch to remove this code. > > >Cheers, >Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
