On Wed, 11 Mar 2009 21:00:19 -0400
Devin Heitmueller <devin.heitmueller@xxxxxxxxx> wrote:
> Hello Mauro,
>
> Please apply one additional patch for the series I sent this morning:
>
> - au0828: make sure v4l2_device name is unique
>
> Thanks,
>
> Devin
>
+static int vidioc_querycap(struct file *file, void *priv,
+ struct v4l2_capability *cap)
+{
+ struct au0828_fh *fh = priv;
+ struct au0828_dev *dev = fh->dev;
+
+ memset(cap, 0, sizeof(*cap));
Please remove all memsets for input/output arguments on vidioc_foo at au0828-video.c.
The V4L2 core warrants that the non-input fields are zeroed.
+static int vidioc_enum_fmt_vid_cap(struct file *file, void *priv,
+ struct v4l2_fmtdesc *f)
+{
+ if(f->index)
+ return -EINVAL;
+
+ memset(f, 0, sizeof(*f));
+ f->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+ strcpy(f->description, "Packed YUV2");
+
+ f->flags = 0;
+ f->pixelformat = V4L2_PIX_FMT_UYVY;
+
+ memset(f->reserved, 0, sizeof(f->reserved));
+ return 0;
+}
hmm.. you are cleaning up f->reserved three times: at v4l2-ioctl, at the
memset(f) and at memset(f->reserved).
You really wanted to make sure that you've cleaned it, don't you? ;)
hmm...
+#ifdef VBI_NOT_YET_WORKING
+ .vidioc_g_fmt_vbi_cap = vidioc_g_fmt_vbi_cap,
+ .vidioc_try_fmt_vbi_cap = vidioc_s_fmt_vbi_cap,
+ .vidioc_s_fmt_vbi_cap = vidioc_s_fmt_vbi_cap,
+#endif
I don't see any reference of this macro. If VBI is working, please cleanup the
driver. Btw, your logic seems to be inverted on some cases. Why are you adding
VBI macros, if it is not working yet?
On the other hand, if VBI is broken we'll need some rules for removing vbi code
from upstream, at gentree.pl.
+enum au0828_itype {
+ AU0828_VMUX_UNDEFINED = 0,
+ AU0828_VMUX_COMPOSITE,
+ AU0828_VMUX_SVIDEO,
+ AU0828_VMUX_CABLE,
+ AU0828_VMUX_TELEVISION,
+ AU0828_VMUX_DVB,
+ AU0828_VMUX_DEBUG
+};
...
+static int vidioc_enum_input(struct file *file, void *priv,
+ struct v4l2_input *input)
+{
+ struct au0828_fh *fh = priv;
+ struct au0828_dev *dev = fh->dev;
+ unsigned int tmp;
+
+ static const char *inames[] = {
+ [AU0828_VMUX_COMPOSITE] = "Composite",
+ [AU0828_VMUX_SVIDEO] = "S-Video",
+ [AU0828_VMUX_CABLE] = "Cable TV",
+ [AU0828_VMUX_TELEVISION] = "Television",
+ [AU0828_VMUX_DVB] = "DVB",
+ [AU0828_VMUX_DEBUG] = "tv debug"
+ };
If the user enumerates an entry marked as UNDEFINED, it will print NULL. Is it
what you really wanted? I would, instead, assign another value for
AU0828_VMUX_UNDEFINED, like -1.
+ switch(AUVI_INPUT(index).type) {
+ case AU0828_VMUX_SVIDEO:
+ {
+ dev->input_type = AU0828_VMUX_SVIDEO;
+ break;
+ }
+ case AU0828_VMUX_COMPOSITE:
+ {
+ dev->input_type = AU0828_VMUX_COMPOSITE;
+ break;
+ }
+ case AU0828_VMUX_TELEVISION:
+ {
+ dev->input_type = AU0828_VMUX_TELEVISION;
+ break;
+ }
+ default:
+ ;
+ }
You don't need all those braces.
Also, the default rule is missing. I don't see why you would preserve the same
dev->input_type if the user selects an undefined entry, or a DVB or a debug.
Ah, finally, there are a number of CodingStyle fun. I've enclosed what it got,
from the final code. Please, always use make checkpatch before committing a patch.
Cheers,
Mauro
/home/v4l/master/linux/drivers/media/dvb/frontends/au8522_dig.c: In ' printk(arg); \':
/home/v4l/master/linux/drivers/media/dvb/frontends/au8522_dig.c:40: warning: suspect code indent for conditional statements (8, 17)
/home/v4l/master/linux/drivers/media/dvb/frontends/au8522_dig.c: In ' u8 buf [] = { (reg >> 8) | 0x80, reg & 0xff, data };':
/home/v4l/master/linux/drivers/media/dvb/frontends/au8522_dig.c:48: ERROR: space prohibited before open square bracket '['
/home/v4l/master/linux/drivers/media/dvb/frontends/au8522_dig.c: In ' u8 b0 [] = { (reg >> 8) | 0x40, reg & 0xff };':
/home/v4l/master/linux/drivers/media/dvb/frontends/au8522_dig.c:65: ERROR: space prohibited before open square bracket '['
/home/v4l/master/linux/drivers/media/dvb/frontends/au8522_dig.c: In ' u8 b1 [] = { 0 };':
/home/v4l/master/linux/drivers/media/dvb/frontends/au8522_dig.c:66: ERROR: space prohibited before open square bracket '['
/home/v4l/master/linux/drivers/media/dvb/frontends/au8522_dig.c: In ' struct i2c_msg msg [] = {':
/home/v4l/master/linux/drivers/media/dvb/frontends/au8522_dig.c:68: ERROR: space prohibited before open square bracket '['
/home/v4l/master/linux/drivers/media/video/au0828/au0828-cards.c: In ' }':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-cards.c:205: warning: braces {} are not necessary for single statement blocks
/home/v4l/master/linux/drivers/media/video/au0828/au0828-cards.c: In ' printk("analog subdev registration failure\n");':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-cards.c:206: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au0828/au0828-cards.c: In ' }':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-cards.c:215: warning: braces {} are not necessary for single statement blocks
/home/v4l/master/linux/drivers/media/video/au0828/au0828-cards.c: In ' printk("analog tuner subdev registration failure\n");':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-cards.c:216: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au0828/au0828-i2c.c: In ' } else {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-i2c.c:149: warning: braces {} are not necessary for any arm of this statement
/home/v4l/master/linux/drivers/media/video/au0828/au0828-i2c.c: In ' } else {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-i2c.c:227: warning: braces {} are not necessary for any arm of this statement
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In '#include <linux/videodev.h>':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:35: ERROR: Don't use <linux/videodev.h>: see Documentation/feature-removal-schedule.txt
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In 'void au0828_analog_stream_reset(struct au0828_dev *dev);':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:50: warning: externs should be avoided in .c files
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' printk("v4l2 ioctl: device is misconfigured; "':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:115: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' au0828_isocdbg("Overflow of %zi bytes past buffer end (2)\n",':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:380: warning: line over 80 characters
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' }':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:396: warning: braces {} are not necessary for single statement blocks
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' }':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:464: warning: braces {} are not necessary for single statement blocks
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' } else':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:487: warning: braces {} are not necessary for any arm of this statement
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' } else {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:494: warning: braces {} are not necessary for any arm of this statement
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' }':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:503: warning: braces {} are not necessary for single statement blocks
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' printk("au0828_init_isoc failed\n");':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:586: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(dev->dev_state == DEV_DISCONNECTED)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:688: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' else if(ret) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:690: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' dprintk(1, "%s device is misconfigured!\n", __FUNCTION__);':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:692: warning: __func__ should be used instead of gcc specific __FUNCTION__
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(h->vdev->minor == minor) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:760: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(h->vbi_dev->minor == minor) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:765: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(NULL == dev)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:772: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(NULL == fh) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:776: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(fh->type == V4L2_BUF_TYPE_VIDEO_CAPTURE && dev->users == 0) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:785: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(ret < 0) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:788: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' printk("Au0828 can't set alt setting to 5!\n");':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:789: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(dev->users == 1) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:828: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(dev->dev_state & DEV_DISCONNECTED) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:832: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(ret < 0)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:846: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' printk("Au0828 can't set alt setting to 0!\n");':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:847: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(fh->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:868: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(format->type == V4L2_BUF_TYPE_SLICED_VBI_CAPTURE) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:944: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(format->type == V4L2_BUF_TYPE_VBI_CAPTURE) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:948: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' }':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:948: warning: braces {} are not necessary for single statement blocks
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(format->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:952: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' }':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:952: warning: braces {} are not necessary for single statement blocks
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' }':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:958: warning: braces {} are not necessary for single statement blocks
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(width != 720)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:963: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(height != 480)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:965: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(cmd == VIDIOC_TRY_FMT)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:976: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(dev->stream_state == STREAM_ON) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:986: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if((ret = au0828_stream_interrupt(dev))) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:988: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if((ret = au0828_stream_interrupt(dev))) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:988: ERROR: do not use assignment in if condition
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(ret < 0) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:996: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' printk("Au0828 can't set alt setting to 5!\n");':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:997: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(f->index)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1047: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' printk("%s queue busy\n", __func__);':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1094: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' printk("%s device in use by another fh\n", __func__);':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1100: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(tmp > AU0828_MAX_INPUT)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1141: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(AUVI_INPUT(tmp).type == 0)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1143: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if((AUVI_INPUT(tmp).type == AU0828_VMUX_TELEVISION) ||':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1149: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' dprintk(1, "VIDIOC_S_INPUT in function %s, input=%d\n", __FUNCTION__,':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1175: warning: __func__ should be used instead of gcc specific __FUNCTION__
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(index >= AU0828_MAX_INPUT)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1177: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(AUVI_INPUT(index).type == 0)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1179: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' switch(AUVI_INPUT(index).type) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1183: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' }':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1209: warning: braces {} are not necessary for single statement blocks
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(a->index > 1)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1241: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(index == 0)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1246: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(a->index != dev->ctrl_ainput)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1260: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(t->index != 0)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1290: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(t->index != 0)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1306: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(freq->tuner != 0)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1334: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(freq->type != V4L2_TUNER_ANALOG_TV)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1336: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(cc->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1374: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if((ret = au0828_stream_interrupt(dev)) != 0)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1438: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if((ret = au0828_stream_interrupt(dev)) != 0)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1438: ERROR: do not use assignment in if condition
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' }':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1443: warning: braces {} are not necessary for single statement blocks
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' interface->cur_altsetting->desc.bInterfaceNumber, 5);':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1638: warning: line over 80 characters
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' printk("Failure setting usb interface0 to as5\n");':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1640: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' for(i = 0; i < iface_desc->desc.bNumEndpoints; i++){':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1646: ERROR: space required before the open brace '{'
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' for(i = 0; i < iface_desc->desc.bNumEndpoints; i++){':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1646: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(((endpoint->bEndpointAddress & USB_ENDPOINT_DIR_MASK) == USB_DIR_IN) &&':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1648: warning: line over 80 characters
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(((endpoint->bEndpointAddress & USB_ENDPOINT_DIR_MASK) == USB_DIR_IN) &&':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1648: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) == USB_ENDPOINT_XFER_ISOC)){':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1649: warning: line over 80 characters
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) == USB_ENDPOINT_XFER_ISOC)){':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1649: ERROR: space required before the open brace '{'
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' dev->max_pkt_size = (tmp & 0x07ff) * (((tmp & 0x1800) >> 11) + 1);':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1653: warning: line over 80 characters
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(!(dev->isoc_in_endpointaddr)) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1657: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' printk("Could not locate isoc endpoint\n");':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1658: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(NULL == dev->vdev) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1679: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if(NULL == dev->vbi_dev) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1686: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if((retval = video_register_device(dev->vdev, VFL_TYPE_GRABBER, -1)) != 0) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1710: warning: line over 80 characters
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if((retval = video_register_device(dev->vdev, VFL_TYPE_GRABBER, -1)) != 0) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1710: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if((retval = video_register_device(dev->vdev, VFL_TYPE_GRABBER, -1)) != 0) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1710: ERROR: do not use assignment in if condition
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' dprintk(1, "unable to register video device (error = %d).\n", retval);':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1711: warning: line over 80 characters
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if((retval = video_register_device(dev->vbi_dev, VFL_TYPE_VBI, -1)) != 0) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1719: warning: line over 80 characters
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if((retval = video_register_device(dev->vbi_dev, VFL_TYPE_VBI, -1)) != 0) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1719: ERROR: space required before the open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' if((retval = video_register_device(dev->vbi_dev, VFL_TYPE_VBI, -1)) != 0) {':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1719: ERROR: do not use assignment in if condition
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' dprintk(1, "unable to register vbi device (error = %d).\n", retval);':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1720: warning: line over 80 characters
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c: In ' dprintk(1, "%s completed!\n", __FUNCTION__);':
/home/v4l/master/linux/drivers/media/video/au0828/au0828-video.c:1728: warning: __func__ should be used instead of gcc specific __FUNCTION__
/home/v4l/master/linux/drivers/media/video/au0828/au0828.h: In '#define AU0828_ISO_BUFFER_SIZE (AU0828_ISO_PACKETS_PER_URB * AU0828_ISO_MAX_FRAME_SIZE)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828.h:58: warning: line over 80 characters
/home/v4l/master/linux/drivers/media/video/au0828/au0828.h: In '#define AU0828_URB_TIMEOUT msecs_to_jiffies(AU0828_MAX_ISO_BUFS * AU0828_ISO_PACKETS_PER_URB)':
/home/v4l/master/linux/drivers/media/video/au0828/au0828.h:65: warning: line over 80 characters
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R410, {0x25, 0x00, 0x25, 0x25, 0x00, 0x00, 0x00}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:71: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R411, {0x20, 0x00, 0x20, 0x20, 0x00, 0x00, 0x00}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:72: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R412, {0x03, 0x00, 0x03, 0x03, 0x00, 0x00, 0x00}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:73: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R413, {0xe6, 0x00, 0xe6, 0xe6, 0x00, 0x00, 0x00}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:74: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R414, {0x40, 0x00, 0x40, 0x40, 0x00, 0x00, 0x00}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:75: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R415, {0x1b, 0x00, 0x1b, 0x1b, 0x00, 0x00, 0x00}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:76: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R416, {0xc0, 0x00, 0xc0, 0x04, 0x00, 0x00, 0x00}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:77: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R417, {0x04, 0x00, 0x04, 0x04, 0x00, 0x00, 0x00}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:78: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R418, {0x8c, 0x00, 0x8c, 0x8c, 0x00, 0x00, 0x00}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:79: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R419, {0xa0, 0x40, 0xa0, 0xa0, 0x40, 0x40, 0x40}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:80: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R41A, {0x21, 0x09, 0x21, 0x21, 0x09, 0x09, 0x09}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:81: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R41B, {0x6c, 0x38, 0x6c, 0x6c, 0x38, 0x38, 0x38}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:82: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R41C, {0x03, 0xff, 0x03, 0x03, 0xff, 0xff, 0xff}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:83: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R41D, {0xbf, 0xc7, 0xbf, 0xbf, 0xc7, 0xc7, 0xc7}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:84: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R41E, {0xa0, 0xdf, 0xa0, 0xa0, 0xdf, 0xdf, 0xdf}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:85: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R41F, {0x10, 0x06, 0x10, 0x10, 0x06, 0x06, 0x06}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:86: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R420, {0xae, 0x30, 0xae, 0xae, 0x30, 0x30, 0x30}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:87: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R421, {0xc4, 0x01, 0xc4, 0xc4, 0x01, 0x01, 0x01}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:88: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R422, {0x54, 0xdd, 0x54, 0x54, 0xdd, 0xdd, 0xdd}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:89: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R423, {0xd0, 0xaf, 0xd0, 0xd0, 0xaf, 0xaf, 0xaf}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:90: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R424, {0x1c, 0xf7, 0x1c, 0x1c, 0xf7, 0xf7, 0xf7}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:91: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R425, {0x76, 0xdb, 0x76, 0x76, 0xdb, 0xdb, 0xdb}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:92: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R426, {0x61, 0xc0, 0x61, 0x61, 0xc0, 0xc0, 0xc0}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:93: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R427, {0xd1, 0x2f, 0xd1, 0xd1, 0x2f, 0x2f, 0x2f}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:94: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R428, {0x84, 0xd8, 0x84, 0x84, 0xd8, 0xd8, 0xd8}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:95: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R429, {0x06, 0xfb, 0x06, 0x06, 0xfb, 0xfb, 0xfb}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:96: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R42A, {0x21, 0xd5, 0x21, 0x21, 0xd5, 0xd5, 0xd5}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:97: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R42B, {0x0a, 0x3e, 0x0a, 0x0a, 0x3e, 0x3e, 0x3e}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:98: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R42C, {0xe6, 0x15, 0xe6, 0xe6, 0x15, 0x15, 0x15}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:99: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {AU8522_FILTER_COEF_R42D, {0x01, 0x34, 0x01, 0x01, 0x34, 0x34, 0x34}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:100: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In '#define NUM_FILTER_COEF (sizeof (filter_coef) / sizeof(struct au8522_register_config))':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:103: warning: line over 80 characters
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In '#define NUM_FILTER_COEF (sizeof (filter_coef) / sizeof(struct au8522_register_config))':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:103: warning: space prohibited between function name and open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x060b, {0x21, 0x0b}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:112: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x060c, {0xad, 0xad}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:113: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x060d, {0x70, 0xf0}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:114: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x060e, {0xea, 0xe9}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:115: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x060f, {0xdd, 0xdd}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:116: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0610, {0x08, 0x64}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:117: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0611, {0x60, 0x60}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:118: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0612, {0xf8, 0xb2}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:119: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0613, {0x01, 0x02}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:120: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0614, {0xe4, 0xb4}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:121: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0615, {0x19, 0x02}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:122: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0616, {0xae, 0x2e}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:123: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0617, {0xee, 0xc5}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:124: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0618, {0x56, 0x56}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:125: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0619, {0x30, 0x58}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:126: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x061a, {0xf9, 0xf8}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:127: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x061b, {0x24, 0x64}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:128: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x061c, {0x07, 0x07}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:129: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x061d, {0x30, 0x30}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:130: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x061e, {0xa9, 0xed}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:131: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x061f, {0x09, 0x0b}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:132: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0620, {0x42, 0xc2}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:133: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0621, {0x1d, 0x2a}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:134: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0622, {0xd6, 0x56}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:135: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0623, {0x95, 0x8b}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:136: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0624, {0x2b, 0x2b}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:137: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0625, {0x30, 0x24}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:138: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0626, {0x3e, 0x3e}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:139: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0627, {0x62, 0xe2}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:140: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0628, {0xe9, 0xf5}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:141: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0629, {0x99, 0x19}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:142: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x062a, {0xd4, 0x11}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:143: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x062b, {0x03, 0x04}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:144: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x062c, {0xb5, 0x85}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:145: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x062d, {0x1e, 0x20}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:146: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x062e, {0x2a, 0xea}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:147: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x062f, {0xd7, 0xd2}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:148: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0630, {0x15, 0x15}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:149: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0631, {0xa3, 0xa9}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:150: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0632, {0x1f, 0x1f}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:151: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0633, {0xf9, 0xd1}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:152: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0634, {0xc0, 0xc3}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:153: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0635, {0x4d, 0x8d}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:154: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0636, {0x21, 0x31}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:155: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0637, {0x83, 0x83}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:156: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0638, {0x08, 0x8c}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:157: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0639, {0x19, 0x19}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:158: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x063a, {0x45, 0xa5}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:159: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x063b, {0xef, 0xec}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:160: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x063c, {0x8a, 0x8a}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:161: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x063d, {0xf4, 0xf6}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:162: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x063e, {0x8f, 0x8f}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:163: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x063f, {0x44, 0x0c}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:164: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0640, {0xef, 0xf0}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:165: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0641, {0x66, 0x66}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:166: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0642, {0xcc, 0xd2}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:167: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0643, {0x41, 0x41}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:168: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0644, {0x63, 0x93}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:169: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0645, {0x8e, 0x8e}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:170: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0646, {0xa2, 0x42}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:171: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0647, {0x7b, 0x7b}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:172: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0648, {0x04, 0x04}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:173: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0649, {0x00, 0x00}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:174: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x064a, {0x40, 0x40}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:175: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x064b, {0x8c, 0x98}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:176: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x064c, {0x00, 0x00}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:177: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x064d, {0x63, 0xc3}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:178: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x064e, {0x04, 0x04}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:179: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x064f, {0x20, 0x20}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:180: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0650, {0x00, 0x00}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:181: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0651, {0x40 ,0x40}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:182: ERROR: space required after that ',' (ctx:WxV)
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0651, {0x40 ,0x40}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:182: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' {0x0652, {0x01, 0x01}},':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:183: ERROR: space required after that close brace '}'
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In '#define NUM_LPFILTER_COEF (sizeof (lpfilter_coef) / sizeof(struct au8522_register_config))':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:185: warning: line over 80 characters
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In '#define NUM_LPFILTER_COEF (sizeof (lpfilter_coef) / sizeof(struct au8522_register_config))':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:185: warning: space prohibited between function name and open parenthesis '('
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' au8522_writereg(state, AU8522_TVDEC_VBI_USER_FRAME_MASK2_REG021H,0x00);':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:206: ERROR: space required after that ',' (ctx:VxV)
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' au8522_writereg(state, AU8522_TVDEC_VBI_USER_FRAME_MASK1_REG022H,0x00);':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:207: ERROR: space required after that ',' (ctx:VxV)
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' au8522_writereg(state, AU8522_TVDEC_VBI_USER_FRAME_MASK0_REG023H,0x00);':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:208: ERROR: space required after that ',' (ctx:VxV)
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' }':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:211: warning: braces {} are not necessary for single statement blocks
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' printk("Unsupported audio mode requested! mode=%d\n",':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:452: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' printk("au8522 mode not currently supported\n");':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:672: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' printk("au8522_decoder allocation failed\n");':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:786: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' printk("au8522_decoder creating new instance...\n");':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:790: warning: printk() should include KERN_ facility level
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c: In ' printk("au8522_decoder attaching to existing instance...\n");':
/home/v4l/master/linux/drivers/media/video/au8522_decoder.c:794: warning: printk() should include KERN_ facility level
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
