Re: [PULL] http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2009-03-11 at 11:25 -0400, Devin Heitmueller wrote:
> Hello Mauro,
> 
> Please pull from:
> 
> http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2
> 
> for the following:
[snip]
> au0828: Convert to use v4l2_device/subdev framework



+	/* Create the v4l2_device */ 
+	snprintf(dev->v4l2_dev.name, sizeof(dev->v4l2_dev.name), "%s-%03d", 
+		 "au0828", 0); 
+	retval = v4l2_device_register(&dev->usbdev->dev, &dev->v4l2_dev); 

If you're not going to differentiate between different instances of
au0828 devices connectred to the system in log messages, you may wish to
get rid of the '"-%03d"' and ',0' in the snprintf().

Or maybe you could use "dev->usbdev->dev.bus_id" somehow to indicate the
instance in the name?


Regards,
Andy

> Cheers,
> 
> Devin


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux