On Wed, Mar 11, 2009 at 3:44 PM, Andy Walls <awalls@xxxxxxxxx> wrote: > > + /* Create the v4l2_device */ > + snprintf(dev->v4l2_dev.name, sizeof(dev->v4l2_dev.name), "%s-%03d", > + "au0828", 0); > + retval = v4l2_device_register(&dev->usbdev->dev, &dev->v4l2_dev); > > If you're not going to differentiate between different instances of > au0828 devices connectred to the system in log messages, you may wish to > get rid of the '"-%03d"' and ',0' in the snprintf(). > > Or maybe you could use "dev->usbdev->dev.bus_id" somehow to indicate the > instance in the name? Doh. Yeah, I jammed the zero in there when I was trying to bootstrap the conversion, and then I forgot about it. Mauro, any objection to me submitting this as a separate patch tonight when I get home? This is a large series of patches and I would prefer to get them in before somebody else submits something that requires me to rebase again (and while I agree with Andy that it should be fixed, it doesn't actually result in any sort of regression). Cheers, Devin -- Devin J. Heitmueller http://www.devinheitmueller.com AIM: devinheitmueller -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
