On Mon, 9 Mar 2009 23:33:38 +0100 Tobias Lorenz <tobias.lorenz@xxxxxxx> wrote: > Hi, > > > The proper way is to break radio-si470x into two parts: > > > > - A i2c adapter driver (similar to what we have on cx88-i2c, for > > example, plus the radio part of cx88-video); > > - A radio driver (similar to tea5767.c). > > > > This way, the i2c driver can be used on designs that use a different i2c adapter. > > yes, this is why I already capsulated most of the USB functionality into own functions. I awaited that somewhen the si470x is used in the "usual" way by i2c. > > I'm not sure, if we should split the driver into three files (generic/common, usb, i2c) or just implement the new functionality within the same file using macros/defines. It is better to split. It will provide more flexibility. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html