On Fri, 6 Mar 2009 12:13:05 +0900 Joonyoung Shim <dofmind@xxxxxxxxx> wrote: > Hi all, > > I have worked with Silicon Labs Si4709 chip using the I2C interface. > There is the radio-si470x driver in linux-kernel, but it uses usb interface. > > First, i made a new file based on radio-si470x.c in driver/media/radio/ for > si4709 i2c driver and modified it to use i2c interface instead of usb > interface and could listen to FM radio station. > > I think it can be to join two things together to one file because there isn't > the difference between the two except for the interface. > I am considering how to integrate them. > > Please send your opinion. > The proper way is to break radio-si470x into two parts: - A i2c adapter driver (similar to what we have on cx88-i2c, for example, plus the radio part of cx88-video); - A radio driver (similar to tea5767.c). This way, the i2c driver can be used on designs that use a different i2c adapter. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html