On Tue, 2023-07-04 at 17:44 +1200, Michael Schmitz wrote:
Hi Adrian,
Am 04.07.2023 um 17:06 schrieb John Paul Adrian Glaubitz:
Hi Michael!
On Tue, 2023-07-04 at 09:24 +1200, Michael Schmitz wrote:
Hi Christian,
On 4/07/23 02:59, Christian Zigotzky wrote:
I am very happy that this bug is fixed now but we have to explain it
to our customers why they can't mount their Linux partitions on the
RDB disk anymore. Booting is of course also affected. (Mounting the
root partition)
But maybe simple GParted instructions are a good solution.
You can apply the patch. I will revert this patch until I find a
simple solution for our community.
Thank you for fixing this issue!
Thanks for testing - I'll add your Tested-by: tag now. I have to correct
the Fixes: tag anyway.
Have we actually agreed now that this is a bug and not just an effect of the
corrupted RDB that Christian provided?
The RDB was perfectly fine. Due to 32 bit integer arithmetic overflow,
old RDB code passed an incorrect partition size to put_partition(),
and instead of rejecting a partition that extends past the end of the
disk, put_partition() truncated the size.
OK, so using "-1" as an end-of-disk partition marker is fine, but it was just
the partition size recorded in Christian's RDB that was incorrect, correct?
Jens - is the bugfix patch enough, or do you need a new version of the
entire series?
But the series has already been applied and released in 6.4, hasn't it?
That's right - I wasn't sure whether it had already gone upstream (but
even then, squeezing a bugfix in with an accepted patch isn't usually done).
It's even released already ;-). That's why Christian ran into the problem in the
first place.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
