Re: [PATCH] 2.6.19 m68k Atari: SCC serial support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 11 Dec 2006, Michael Schmitz wrote:
my SCC serial driver - this one works less well in 2.6 than it did in 2.4,
most likely due to the way flip buffer push is handled now - i.e. no
immediate push of received characters to the line disc. if the handler
runs in interrupt context, and the bottom half for pushing is run as
delayed task. 9 out of 10 ping packets end up in the bit bucket this way.
I haven't figured out how to prevent overruns yet, and getting this right
will require a bit more testing.

Anyway, the basics are working, and maybe someone can figure out a better
way to push characters up to the ldisc.

Signed-Off-By: <schmitz@xxxxxxxxxx>

SCC_clocks is unused. Is this intentional?

Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

--- linux-m68k-2.6.19.orig/drivers/char/atari_scc.c	2006-12-12 21:52:31.000000000 +0100
+++ linux-m68k-2.6.19/drivers/char/atari_scc.c	2006-12-12 21:52:31.000000000 +0100
@@ -145,12 +145,6 @@ static struct tty_operations scc_ops = {
 	.break_ctl = scc_break_ctl,
 };
 
-static unsigned SCC_clocks[2][2] = {
-	  /* RTxC */			/* TRxC */
-	{ SCC_BAUD_BASE_PCLK4,	SCC_BAUD_BASE_NONE },	/* Channel A */
-	{ SCC_BAUD_BASE_TIMC,	SCC_BAUD_BASE_BCLK }	/* Channel B */
-};
-
 /* BRG values for the standard speeds and the various clock sources */
 
 typedef struct {

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux