On Fri 2021-10-22 08:42:06, Jiri Kosina wrote: > On Mon, 18 Oct 2021, Jiri Kosina wrote: > > > > Ok, so let's put it in the common place. I'll take this patch through > > > LED tree if you resubmit it. You still may want to use local defines > > > so you can apply the other patches without waiting. > > > > Pavel, why complicate it so much? Given how trivial the patch is, the > > easiest way is what's usually done in such cases (where substantial patch > > depends on a tiny trivial change elsewhere) -- take it through HID tree > > with your Reviewed-by / Acked-by:. > > > > Do you see any issue with that? > > Pavel, another week has passed. I am considering just including the > trivial LED #define additions and take them through hid.git unless I hear > from you today. I'd prefer not to deal with rejects / common immutable branches / etc. You don't _need_ the defines at all, and you don't need them in the common place. Just merge the patch without the defines. I'll merge the defines. That seems like least complex solution to me. Pavel -- http://www.livejournal.com/~pavelmachek
Attachment:
signature.asc
Description: Digital signature
