Hi Uwe,
On 06/26/2018 11:03 AM, Uwe Kleine-König wrote:
On Tue, May 22, 2018 at 10:07:52PM +0200, Jacek Anaszewski wrote:
On 05/22/2018 09:53 PM, Uwe Kleine-König wrote:
Hello Jacek,
On Tue, May 22, 2018 at 09:34:06PM +0200, Jacek Anaszewski wrote:
I think that we shouldn't apply this patch alone,
but it should be immediately followed by the one
employing yet to be implemented tty trigger.
note that the (already existing) netdev trigger is the one that should
replace the can trigger, not the tty one.
In this way we're removing the functionality, without
providing the substitute.
So this conclusion is wrong.
OK, so waiting for CAN maintainer's ack.
Given that we're still waiting and this patch is in the way for my
cleanup series, what about:
----->8-----------
From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Date: Tue, 26 Jun 2018 10:57:59 +0200
Subject: [PATCH] can: mark led trigger as broken
The driver was suggested for deletion as it implements a subset of the
netdev trigger. It's in the way for further cleanups in the trigger
code but doesn't get an Ack by someone who can actually test and confirm
that the netdev trigger works for can devices. So marking as broken to
get forward with the cleanups.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
---
drivers/net/can/Kconfig | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
index 2cb75988b328..7cdd0cead693 100644
--- a/drivers/net/can/Kconfig
+++ b/drivers/net/can/Kconfig
@@ -73,6 +73,12 @@ config CAN_CALC_BITTIMING
config CAN_LEDS
bool "Enable LED triggers for Netlink based drivers"
depends on LEDS_CLASS
+ # The netdev trigger (LEDS_TRIGGER_NETDEV) should be able to do
+ # everything that this driver is doing. This is marked as broken
+ # because it uses stuff that is intended to be changed or removed.
+ # Please consider switching to the netdev trigger and confirm it
+ # fulfills your needs instead of fixing this driver.
+ depends on BROKEN
select LEDS_TRIGGERS
---help---
This option adds two LED triggers for packet receive and transmit
Good idea. Please submit the patch officially.
--
Best regards,
Jacek Anaszewski
