> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > Date: Tue, 26 Jun 2018 10:57:59 +0200 > Subject: [PATCH] can: mark led trigger as broken > > The driver was suggested for deletion as it implements a subset of the > netdev trigger. It's in the way for further cleanups in the trigger > code but doesn't get an Ack by someone who can actually test and confirm > that the netdev trigger works for can devices. So marking as broken to > get forward with the cleanups. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Acked-by: Pavel Machek <pavel@xxxxxx> > > diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig > index 2cb75988b328..7cdd0cead693 100644 > --- a/drivers/net/can/Kconfig > +++ b/drivers/net/can/Kconfig > @@ -73,6 +73,12 @@ config CAN_CALC_BITTIMING > config CAN_LEDS > bool "Enable LED triggers for Netlink based drivers" > depends on LEDS_CLASS > + # The netdev trigger (LEDS_TRIGGER_NETDEV) should be able to do > + # everything that this driver is doing. This is marked as broken > + # because it uses stuff that is intended to be changed or removed. > + # Please consider switching to the netdev trigger and confirm it > + # fulfills your needs instead of fixing this driver. > + depends on BROKEN > select LEDS_TRIGGERS > ---help--- > This option adds two LED triggers for packet receive and transmit > > Best regards > Uwe > -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
