Re: [PATCH] leds: triggers: don't depend on LEDS_TRIGGERS twice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Uwe,

Thank you for the patch.

On 06/26/2018 11:37 AM, Uwe Kleine-König wrote:
All the triggers are defined in a big if LEDS_TRIGGERS...endif block.
So there is no need to let each driver depend on LEDS_TRIGGERS explicitly
once more.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
---
  drivers/leds/trigger/Kconfig | 15 +--------------
  1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/drivers/leds/trigger/Kconfig b/drivers/leds/trigger/Kconfig
index a2559b4fdfff..4018af769969 100644
--- a/drivers/leds/trigger/Kconfig
+++ b/drivers/leds/trigger/Kconfig
@@ -10,7 +10,6 @@ if LEDS_TRIGGERS
config LEDS_TRIGGER_TIMER
  	tristate "LED Timer Trigger"
-	depends on LEDS_TRIGGERS
  	help
  	  This allows LEDs to be controlled by a programmable timer
  	  via sysfs. Some LED hardware can be programmed to start
@@ -21,7 +20,6 @@ config LEDS_TRIGGER_TIMER
config LEDS_TRIGGER_ONESHOT
  	tristate "LED One-shot Trigger"
-	depends on LEDS_TRIGGERS
  	help
  	  This allows LEDs to blink in one-shot pulses with parameters
  	  controlled via sysfs.  It's useful to notify the user on
@@ -36,7 +34,6 @@ config LEDS_TRIGGER_ONESHOT
  config LEDS_TRIGGER_DISK
  	bool "LED Disk Trigger"
  	depends on IDE_GD_ATA || ATA
-	depends on LEDS_TRIGGERS
  	help
  	  This allows LEDs to be controlled by disk activity.
  	  If unsure, say Y.
@@ -44,14 +41,12 @@ config LEDS_TRIGGER_DISK
  config LEDS_TRIGGER_MTD
  	bool "LED MTD (NAND/NOR) Trigger"
  	depends on MTD
-	depends on LEDS_TRIGGERS
  	help
  	  This allows LEDs to be controlled by MTD activity.
  	  If unsure, say N.
config LEDS_TRIGGER_HEARTBEAT
  	tristate "LED Heartbeat Trigger"
-	depends on LEDS_TRIGGERS
  	help
  	  This allows LEDs to be controlled by a CPU load average.
  	  The flash frequency is a hyperbolic function of the 1-minute
@@ -60,7 +55,6 @@ config LEDS_TRIGGER_HEARTBEAT
config LEDS_TRIGGER_BACKLIGHT
  	tristate "LED backlight Trigger"
-	depends on LEDS_TRIGGERS
  	help
  	  This allows LEDs to be controlled as a backlight device: they
  	  turn off and on when the display is blanked and unblanked.
@@ -69,7 +63,6 @@ config LEDS_TRIGGER_BACKLIGHT
config LEDS_TRIGGER_CPU
  	bool "LED CPU Trigger"
-	depends on LEDS_TRIGGERS
  	help
  	  This allows LEDs to be controlled by active CPUs. This shows
  	  the active CPUs across an array of LEDs so you can see which
@@ -79,7 +72,6 @@ config LEDS_TRIGGER_CPU
config LEDS_TRIGGER_ACTIVITY
  	tristate "LED activity Trigger"
-	depends on LEDS_TRIGGERS
  	help
  	  This allows LEDs to be controlled by an immediate CPU usage.
  	  The flash frequency and duty cycle varies from faint flashes to
@@ -88,7 +80,6 @@ config LEDS_TRIGGER_ACTIVITY
config LEDS_TRIGGER_GPIO
  	tristate "LED GPIO Trigger"
-	depends on LEDS_TRIGGERS
  	depends on GPIOLIB || COMPILE_TEST
  	help
  	  This allows LEDs to be controlled by gpio events. It's good
@@ -101,7 +92,6 @@ config LEDS_TRIGGER_GPIO
config LEDS_TRIGGER_DEFAULT_ON
  	tristate "LED Default ON Trigger"
-	depends on LEDS_TRIGGERS
  	help
  	  This allows LEDs to be initialised in the ON state.
  	  If unsure, say Y.
@@ -111,7 +101,6 @@ comment "iptables trigger is under Netfilter config (LED target)"
config LEDS_TRIGGER_TRANSIENT
  	tristate "LED Transient Trigger"
-	depends on LEDS_TRIGGERS
  	help
  	  This allows one time activation of a transient state on
  	  GPIO/PWM based hardware.
@@ -119,7 +108,6 @@ config LEDS_TRIGGER_TRANSIENT
config LEDS_TRIGGER_CAMERA
  	tristate "LED Camera Flash/Torch Trigger"
-	depends on LEDS_TRIGGERS
  	help
  	  This allows LEDs to be controlled as a camera flash/torch device.
  	  This enables direct flash/torch on/off by the driver, kernel space.
@@ -127,7 +115,6 @@ config LEDS_TRIGGER_CAMERA
config LEDS_TRIGGER_PANIC
  	bool "LED Panic Trigger"
-	depends on LEDS_TRIGGERS
  	help
  	  This allows LEDs to be configured to blink on a kernel panic.
  	  Enabling this option will allow to mark certain LEDs as panic indicators,
@@ -137,7 +124,7 @@ config LEDS_TRIGGER_PANIC
config LEDS_TRIGGER_NETDEV
  	tristate "LED Netdev Trigger"
-	depends on NET && LEDS_TRIGGERS
+	depends on NET
  	help
  	  This allows LEDs to be controlled by network device activity.
  	  If unsure, say Y.


Applied.

--
Best regards,
Jacek Anaszewski



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux