Re: [PATCH v3 07/16] leds: timer trigger: simplifications from core changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu 2018-06-14 14:37:46, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> The trigger core learned error handling for the activate callback and
> to handle device attributes. This allows to simplify the driver
> considerably. Note that .deactivate is only called when .new_activate
> succeeded, so the check for trigger_data being non-NULL can go away.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
>  drivers/leds/trigger/ledtrig-timer.c | 57 ++++++++--------------------
>  1 file changed, 15 insertions(+), 42 deletions(-)
> 
>  
>  MODULE_AUTHOR("Richard Purdie <rpurdie@xxxxxxxxxxxxxx>");
>  MODULE_DESCRIPTION("Timer LED trigger");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");

I guess this should go in separately. Maybe I'd even prefer all the
the license fixes in one commit.

Otherwise

Acked-by: Pavel Machek <pavel@xxxxxx>

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux