Hello, compared to v3 I improved the commit logs based on feedback by Pavel and added his acks he gave in v3. There is a new patch (#1) which includes all MODULE_LICENSE changes in a separate change (in v3 some of them were included in the driver's simplification patch). Note that this series breaks the can trigger. Maybe this gives some incentive to get feedback for my patch "can: drop led trigger support". Uwe Kleine-König (17): leds: triggers: make the MODULE_LICENSE string match the actual license leds: triggers: let struct led_trigger::activate() return an error code leds: triggers: add device attribute support leds: triggers: handle .trigger_data and .activated() in the core leds: triggers: define module_led_trigger helper leds: triggers: new function led_set_trigger_data() leds: netdev trigger: simplifications from core changes leds: timer trigger: simplifications from core changes leds: transient trigger: simplifications from core changes leds: oneshot trigger: simplifications from core changes leds: heartbeat trigger: simplifications from core changes leds: default-on trigger: make use of module_led_trigger() leds: activity trigger: simplifications from core changes leds: backlight trigger: simplifications from core changes leds: gpio trigger: simplifications from core changes usb: simplify usbport trigger WIP: don't apply drivers/leds/led-triggers.c | 38 +++++++- drivers/leds/trigger/ledtrig-activity.c | 46 +++++----- drivers/leds/trigger/ledtrig-backlight.c | 64 +++++--------- drivers/leds/trigger/ledtrig-camera.c | 3 +- drivers/leds/trigger/ledtrig-default-on.c | 20 +---- drivers/leds/trigger/ledtrig-gpio.c | 92 ++++++------------- drivers/leds/trigger/ledtrig-heartbeat.c | 49 +++++------ drivers/leds/trigger/ledtrig-netdev.c | 101 +++++++-------------- drivers/leds/trigger/ledtrig-oneshot.c | 91 ++++++------------- drivers/leds/trigger/ledtrig-timer.c | 58 ++++-------- drivers/leds/trigger/ledtrig-transient.c | 102 +++++++--------------- drivers/tty/vt/keyboard.c | 4 +- drivers/usb/core/ledtrig-usbport.c | 34 +++----- include/linux/leds.h | 42 +++++++-- 14 files changed, 293 insertions(+), 451 deletions(-) -- 2.17.1