On Thu 2018-06-14 14:37:51, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> The trigger core learned error handling for the activate callback and
> to handle device attributes. This allows to simplify the driver
> considerably. Note that .deactivate is only called when .new_activate
> succeeded, so the check for .activated can go away in .deactivate.
>
> Also make use of module_led_trigger() and the accessor function to get
> and set trigger_data.
7-12: Acked-by: Pavel Machek <pavel@xxxxxx> (commit log needs same
fixes in most of them).
> static struct led_trigger activity_led_trigger = {
> - .name = "activity",
> - .activate = activity_activate,
> + .name = "activity",
> + .activate = activity_activate,
> .deactivate = activity_deactivate,
> + .groups = activity_led_groups,
> };
I'd keep existing coding style here.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
