On Thu, 2016-09-29 at 23:14 +0200, Paul Bolle wrote: > On Thu, 2016-09-29 at 13:56 -0700, Joe Perches wrote: > > It doesn't matter match either way to me. > Why does this stop you fixing an apparently wrong checkpatch rule, > crude as parts of it are (ie, uppercase identifier must be a constant)? It doesn't. It just doesn't matter much (match) to me. Here: --- scripts/checkpatch.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3373c65fef1c..fc931d89152e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -5835,8 +5835,8 @@ sub process { if ($^V && $^V ge 5.10.0 && $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)\s*,/) { my $oldfunc = $3; - my $a1 = $4; - my $a2 = $10; + my $a1 = trim($4); + my $a2 = trim($10); my $newfunc = "kmalloc_array"; $newfunc = "kcalloc" if ($oldfunc eq "kzalloc"); my $r1 = $a1; @@ -5850,7 +5850,7 @@ sub process { if (WARN("ALLOC_WITH_MULTIPLY", "Prefer $newfunc over $oldfunc with multiply\n" . $herecurr) && $fix) { - $fixed[$fixlinenr] =~ s/\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)/$1 . ' = ' . "$newfunc(" . trim($r1) . ', ' . trim($r2)/e; + $fixed[$fixlinenr] =~ s/\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)/$1 . ' = ' . "$newfunc(" . $r1 . ', ' . $r2/e; } } -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html