On Thu, 2016-09-29 at 11:54 +0200, Paul Bolle wrote: > Andy, Joe, > > On Thu, 2016-09-29 at 11:07 +0200, SF Markus Elfring wrote: > > * Multiplications for the size determination of memory allocations > > indicated that array data structures should be processed. > > Thus use the corresponding function "kmalloc_array". > > > > This issue was detected by using the Coccinelle software. > > > We have no hope of fixing Markus' homegrown coccinelle script. But we > could try to fix the checkpatch false positive here. What's the false positive? I get: $ ./scripts/checkpatch.pl -f drivers/md/dm-snap.c --show-types --types=alloc_with_multiply WARNING:ALLOC_WITH_MULTIPLY: Prefer kmalloc_array over kmalloc with multiply #329: FILE: drivers/md/dm-snap.c:329: + _origins = kmalloc(ORIGIN_HASH_SIZE * sizeof(struct list_head), WARNING:ALLOC_WITH_MULTIPLY: Prefer kmalloc_array over kmalloc with multiply #338: FILE: drivers/md/dm-snap.c:338: + _dm_origins = kmalloc(ORIGIN_HASH_SIZE * sizeof(struct list_head), total: 0 errors, 2 warnings, 2490 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. drivers/md/dm-snap.c has style problems, please review. NOTE: Used message types: ALLOC_WITH_MULTIPLY NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
