Re: [PATCH 2/2] mfd: smsc-ece1099: Refactoring for smsc_i2c_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> Which topic would you prefer for my update suggestion instead?
> 
> This one.
> 
> "mfd: smsc-ece1099: Refactoring for smsc_i2c_probe()"
> 
> The function name and just describing the changes as "refactoring" do
> not describe the changes in a helpful way.

Would you find a subject like "mfd: smsc-ece1099: Better exception handling
in smsc_i2c_probe()" acceptable?


>>>> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
>>
>> Do you really request that I should append this tag already to messages
>> for (my adjusted) commits you can not see so far?
> 
> Yes.

Interesting …


> The code looks fine,

Thanks for a bit of positive feedback.


> and if the commit log is still not up to scratch I just won't apply it. :)

Can we eventually agree on an useful message before I would dare another commit?

Will it be sufficient to delete the asterisks there?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux