Please refrain from replying off-list. Adding back the Cc's. On Tue, 12 Jan 2016, SF Markus Elfring wrote: > > Oh, the subject line is also duff. Please describe the changes properly. > > > > "refactoring X", "making changes to Y" are not good subject lines. > > Which topic would you prefer for my update suggestion instead? This one. "mfd: smsc-ece1099: Refactoring for smsc_i2c_probe()" The function name and just describing the changes as "refactoring" do not describe the changes in a helpful way. > >> Code looks fine however. > > Thanks for your look. > > > >> Please re-submit the set with the aforementioned changes along with my: > >> > >> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> > > Do you really request that I should append this tag already to messages > for (my adjusted) commits you can not see so far? Yes. The code looks fine, and if the commit log is still not up to scratch I just won't apply it. :) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
