On Wed, Feb 25, 2015 at 07:37:47PM +0100, Sergei Antonov wrote: > On 25 February 2015 at 19:30, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > Gar. No, I don't care about "if (unlikely(err < 0)" or > > "if (unlikely(err)) ". Those seem like petty things to me so I'm not > > getting involved with the argument between the two of you. (My secret > > real opinion, is that I doubt anyone benchmarked it so probably the > > unlikely() annotations hurt readability for no good reason. In other > > words, "if (err)" is correct.) > > > Thanks for drawing attention to this code anyway. No problem. Please give me a Reported-by if you fix the static checker warning. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
