Re: [patch] hfsplus: add missing curly braces in hfsplus_delete_cat()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 25, 2015 at 03:50:19PM +0100, Sergei Antonov wrote:
> Right you are.
> I would also add 2 things:
> 1. CC the author of the last patch (the one which introduced it).

Huh?  Sougata is CC'd.  I didn't add a fixes: tag because this is just a
cleanup and has no effect on runtime.

> 2. Unify the way the return code from hfsplus_cat_build_key() is
> checked. Now it has two flavours: "if (unlikely(err < 0))" and "if
> (unlikely(err))". The latter is better.

I'm a bit confused.
1) This function uses "if (unlikely(err)) " consistently.
2) I don't see how any of that relates to this patch??

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux