Re: [patch] hfsplus: add missing curly braces in hfsplus_delete_cat()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2015-02-25 at 16:36 +0300, Dan Carpenter wrote:
> This doesn't change how the code works, but clearly the curly braces
> were intended.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Looks good for me.

Thanks,
Vyacheslav Dubeyko.

> 
> diff --git a/fs/hfsplus/catalog.c b/fs/hfsplus/catalog.c
> index 7892e6f..022974a 100644
> --- a/fs/hfsplus/catalog.c
> +++ b/fs/hfsplus/catalog.c
> @@ -350,10 +350,11 @@ int hfsplus_delete_cat(u32 cnid, struct inode *dir, struct qstr *str)
>  			&fd.search_key->cat.name.unicode,
>  			off + 2, len);
>  		fd.search_key->key_len = cpu_to_be16(6 + len);
> -	} else
> +	} else {
>  		err = hfsplus_cat_build_key(sb, fd.search_key, dir->i_ino, str);
>  		if (unlikely(err))
>  			goto out;
> +	}
>  
>  	err = hfs_brec_find(&fd, hfs_find_rec_by_key);
>  	if (err)


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux