On Sun, 09 Mar, at 07:00:53PM, Matthew Garrett wrote: > On Sun, Mar 09, 2014 at 06:50:28PM +0000, Matt Fleming wrote: > > > Is there any value in that? Do machines exist where we absolutely must > > have access to the EFI time services? Either because there's no other > > method or no other working one? > > In theory we get timezones, which we otherwise only get if we have an > ACPI TAD device. We'd previously discussed grabbing this in the EFI stub, before ExitBootServices(), assuming that we only want to get the timezone as opposed to setting it. We don't need phys_* and virt_* functions in the kernel proper for that. > > I can check again, but I'm pretty sure this ASUS machine under my desk > > always returns a vendor-specific error code when invoked, even with > > Borislav's 1:1 patches. Enabling EFI services just because they exist > > hasn't worked out well for us in the past. > > Returning an error doesn't seem like a problem, as long as it's not > actually killing the machine in the process... True, but I don't think that's a good enough justificaton for letting those functions live. If someone can show me a platform where they're needed/advantageous, then that's a different story. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
