On Sun, Mar 09, 2014 at 06:50:28PM +0000, Matt Fleming wrote: > Is there any value in that? Do machines exist where we absolutely must > have access to the EFI time services? Either because there's no other > method or no other working one? In theory we get timezones, which we otherwise only get if we have an ACPI TAD device. > I can check again, but I'm pretty sure this ASUS machine under my desk > always returns a vendor-specific error code when invoked, even with > Borislav's 1:1 patches. Enabling EFI services just because they exist > hasn't worked out well for us in the past. Returning an error doesn't seem like a problem, as long as it's not actually killing the machine in the process... > And of course, the GPF_KERNEL alloc under spinlock bug that started this > thread needs to be fixed. Losing phys_efi_get_time() doesn't seem like it ought to be much of a problem. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html