On Fri, Sep 21, 2012 at 05:24:47AM +0800, Fengguang Wu wrote: > Hi Paul, > > FYI, kernel build failed on > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next > head: d58ab773ab8bc98c81c7d49c04bc88b6e7968385 > commit: 552116942862340a4a0577cbac194ddc6185e4cb [5/78] rcu: Move RCU grace-period cleanup into kthread > config: x86_64-allmodconfig > > All related error/warning messages: > > kernel/rcutree.c: In function 'rcu_gp_kthread': > kernel/rcutree.c:1131:41: error: 'flags' undeclared (first use in this function) > kernel/rcutree.c:1131:41: note: each undeclared identifier is reported only once for each function it appears in > kernel/rcutree.c:1131:74: warning: comparison of distinct pointer types lacks a cast [enabled by default] > kernel/rcutree.c:1176:74: warning: comparison of distinct pointer types lacks a cast [enabled by default] > > vim +1131 kernel/rcutree.c > 1125 if (!ACCESS_ONCE(rnp->qsmask) && > 1126 !rcu_preempt_blocked_readers_cgp(rnp)) > 1127 break; > 1128 flush_signals(current); > 1129 } > 1130 > > 1131 raw_spin_lock_irqsave(&rnp->lock, flags); > 1132 gp_duration = jiffies - rsp->gp_start; > 1133 if (gp_duration > rsp->gp_max) > 1134 rsp->gp_max = gp_duration; <facepalm> I clearly put the raw_spin_lock_irq() conversion in the wrong commit. Fixing, will push the new version shortly. Thanx, Paul -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
